docs(SUP-1768): align jarvOS category framing - #45
Conversation
📝 WalkthroughWalkthroughThis PR refactors jarvOS messaging across documentation, release notes, CLI help, and package metadata to position the project as a portable personal AI operating layer for compatible agent runtimes, replacing prior OpenClaw-specific language with runtime-agnostic framing and explicit runtime-adapter boundaries. ChangesjarvOS Portable Runtime-Agnostic Messaging
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly Related PRs
Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bootstrap.js (1)
171-171:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winInconsistent framing: "OpenClaw workspace path" contradicts runtime-agnostic messaging.
The interactive prompt still uses "OpenClaw workspace path" while the rest of the bootstrap messaging (lines 6, 418) has been updated to runtime-agnostic language. This contradicts the PR objective and may confuse users selecting non-OpenClaw runtimes.
📝 Suggested fix
- ['WORKSPACE_PATH', `OpenClaw workspace path [${defaults.WORKSPACE_PATH}]: `], + ['WORKSPACE_PATH', `Workspace path [${defaults.WORKSPACE_PATH}]: `],🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bootstrap.js` at line 171, The prompt string in the prompts array still reads "OpenClaw workspace path" which contradicts the runtime-agnostic messaging elsewhere; update the array entry that contains the literal "OpenClaw workspace path [${defaults.WORKSPACE_PATH}]: " (referenced alongside defaults.WORKSPACE_PATH) to a runtime-neutral label such as "workspace path" (matching wording used in other prompts/messages) so the prompt no longer mentions OpenClaw explicitly.
🧹 Nitpick comments (2)
package.json (1)
4-5: 💤 Low valueConsider updating keywords to align with runtime-agnostic messaging.
The description now references "compatible agent runtimes" (plural, runtime-agnostic), but the keywords array still singles out "openclaw". While OpenClaw is indeed one compatible runtime, including only it in keywords may undermine the portable, runtime-agnostic positioning. Consider either removing "openclaw" or adding other runtime names like "hermes", "codex", or using a generic keyword like "agent-runtime".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 4 - 5, The keywords array in package.json currently includes "openclaw", which conflicts with the runtime-agnostic wording in the description; update the "keywords" array (the JSON property "keywords") to reflect runtime-agnostic messaging by either removing "openclaw" or replacing/expanding it with generic terms like "agent-runtime" and/or additional runtimes such as "hermes" and "codex" so the package metadata aligns with the plural "compatible agent runtimes".modules/jarvos-skills/README.md (1)
22-37: ⚡ Quick winGeneralize installation examples to match runtime-agnostic messaging.
The introduction now describes "compatible agent runtimes" (plural, runtime-agnostic), but all installation examples still use OpenClaw-specific paths (
/path/to/openclaw-workspace/skills). Consider using a generic placeholder like/path/to/runtime-workspace/skillsor/path/to/agent-runtime/skills, or showing examples for multiple runtimes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@modules/jarvos-skills/README.md` around lines 22 - 37, The README examples use an OpenClaw-specific placeholder; update the installation examples that call scripts/install-skills.js to use a runtime-agnostic placeholder (e.g., /path/to/agent-runtime/skills or /path/to/runtime-workspace/skills) or provide two brief variants for different runtimes, and ensure the --dest examples and the subset install example reference that generic path; locate the lines invoking "node scripts/install-skills.js --dest ..." and replace the "/path/to/openclaw-workspace/skills" occurrences with the chosen neutral placeholder(s).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@bootstrap.js`:
- Line 171: The prompt string in the prompts array still reads "OpenClaw
workspace path" which contradicts the runtime-agnostic messaging elsewhere;
update the array entry that contains the literal "OpenClaw workspace path
[${defaults.WORKSPACE_PATH}]: " (referenced alongside defaults.WORKSPACE_PATH)
to a runtime-neutral label such as "workspace path" (matching wording used in
other prompts/messages) so the prompt no longer mentions OpenClaw explicitly.
---
Nitpick comments:
In `@modules/jarvos-skills/README.md`:
- Around line 22-37: The README examples use an OpenClaw-specific placeholder;
update the installation examples that call scripts/install-skills.js to use a
runtime-agnostic placeholder (e.g., /path/to/agent-runtime/skills or
/path/to/runtime-workspace/skills) or provide two brief variants for different
runtimes, and ensure the --dest examples and the subset install example
reference that generic path; locate the lines invoking "node
scripts/install-skills.js --dest ..." and replace the
"/path/to/openclaw-workspace/skills" occurrences with the chosen neutral
placeholder(s).
In `@package.json`:
- Around line 4-5: The keywords array in package.json currently includes
"openclaw", which conflicts with the runtime-agnostic wording in the
description; update the "keywords" array (the JSON property "keywords") to
reflect runtime-agnostic messaging by either removing "openclaw" or
replacing/expanding it with generic terms like "agent-runtime" and/or additional
runtimes such as "hermes" and "codex" so the package metadata aligns with the
plural "compatible agent runtimes".
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 95c1ea43-5793-42e4-803e-5cf14b7f3bb5
📒 Files selected for processing (9)
README.mdbootstrap.jsdocs/architecture/jarvos-architecture.mddocs/architecture/product-category-and-boundaries.mddocs/releases/v0.1.0.mdmodules/README.mdmodules/jarvos-skills/README.mdmodules/jarvos-skills/package.jsonpackage.json
Thinking Path
What Changed
docs/architecture/product-category-and-boundaries.mdwith category, architecture boundary, and guardrails.Verification
npm testpassed.markdownlint '**/*.md' --ignore 'node_modules/**' --ignore '.github/**' --config .markdownlint.jsonpassed.rg -n "on top of OpenClaw|on top of your OpenClaw|personalization layer|OpenClaw configuration|OpenClaw-style|built on top of OpenClaw" -g '!runtimes/openclaw/**'returned no matches.npm run release:check:candidatereached smoke-test pass but reported the pre-existing release-tag condition:v0.1.0 already exists.Risks
Model Used
OpenAI GPT-5 Codex, coding agent with repository editing, shell verification, and GitHub PR creation capabilities.
Checklist
origin/main..HEADand contains only intended files.Summary by CodeRabbit