Merged
Conversation
Owner
|
Thanks! Exactly, I'd say "Disabled by default" and "enabled by default". But only if the user passed a default bool value. |
We don't want to include it in the `--help` output as a default value.
Owner
|
@TooTallNate You removed the default value for |
Collaborator
Author
|
Yes, Lines 339 to 344 in f838e16 Removing the default value just removed it from the help output ("defaults to v1.0.0" doesn't make much sense). |
--help output--help output
Owner
|
@TooTallNate Great, thanks! ❤️ I have also added you as a collaborator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38.
I also fixed a bug with Boolean types showing
undefinedin the output.Before:
Now:
Thought: for bool types we could say "on" or "enabled" (and "off" or "disabled")
instead of true/false to make the output a little bit more human-friendly.