Fix extension install #7247
Merged
Fix extension install #7247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove old bundled extension dependencies - Make sure external extensions are installed as optional Signed-off-by: Sebastian Malton <[email protected]>
packages/core/src/extensions/install-extension/install-extension.injectable.ts
Outdated
Show resolved
Hide resolved
aleksfront
reviewed
Mar 1, 2023
Contributor
aleksfront
left a comment
There was a problem hiding this comment.
LGTM, fixes bug, extensions got installed successfully. Let's test it more in beta.
Signed-off-by: Sebastian Malton <[email protected]>
Signed-off-by: Sebastian Malton <[email protected]>
Merged
Nokel81
added a commit
that referenced
this pull request
Mar 1, 2023
* Fix extension install - Remove old bundled extension dependencies - Make sure external extensions are installed as optional Signed-off-by: Sebastian Malton <[email protected]> * Ignore ENOENT errors Signed-off-by: Sebastian Malton <[email protected]> * Add comment Signed-off-by: Sebastian Malton <[email protected]> --------- Signed-off-by: Sebastian Malton <[email protected]>
Nokel81
added a commit
that referenced
this pull request
Mar 1, 2023
* General fixes for release-tool (#7238) * General fixes for release-tool Signed-off-by: Sebastian Malton <[email protected]> * Revert change to number of PRs retrieved Signed-off-by: Sebastian Malton <[email protected]> --------- Signed-off-by: Sebastian Malton <[email protected]> * Throw on errors in kubectlApplyFolder (#7239) Signed-off-by: Panu Horsmalahti <[email protected]> * Quick fix for store migration version being wrong (#7243) Signed-off-by: Sebastian Malton <[email protected]> * Revert "Renderer file logging transport (#6795)" (#7245) Renderer file logging still caused UI freezing (at least on apple silicon macs) when cluster frame was open and main frame was reloaded. See #544 This reverts commit ac2d0e4. Signed-off-by: Sami Tiilikainen <[email protected]> * Fix extension install (#7247) * Fix extension install - Remove old bundled extension dependencies - Make sure external extensions are installed as optional Signed-off-by: Sebastian Malton <[email protected]> * Ignore ENOENT errors Signed-off-by: Sebastian Malton <[email protected]> * Add comment Signed-off-by: Sebastian Malton <[email protected]> --------- Signed-off-by: Sebastian Malton <[email protected]> * Release 6.4.0 Signed-off-by: Sebastian Malton <[email protected]> * Fix lint Signed-off-by: Sebastian Malton <[email protected]> --------- Signed-off-by: Sebastian Malton <[email protected]> Signed-off-by: Panu Horsmalahti <[email protected]> Signed-off-by: Sami Tiilikainen <[email protected]> Co-authored-by: Panu Horsmalahti <[email protected]> Co-authored-by: Sami Tiilikainen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7240