Fix kSmallest exponent bug#38
Merged
lemire merged 1 commit intolemire:masterfrom Mar 13, 2023
Merged
Conversation
|
Thank you!! I can confirm that this patch fixes the test suite in jitdb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the calculation for the cloned tree depth in
kSmallestcould overflow, which caused a truncation of the tree. This would start filling the resulting array with incorrect values once at least a number of results was pulled about equal to the tree depth. The remainder of the array would be filled with withundefinedvalues.This still appears to offer a modest performance improvement over the code in
0.7.2while avoiding the bug that was introduced in0.7.3. I settled on this implementation after experimenting with the following.<<) and exponentiation (bothMath.powand**) split at ~31 bitsBigIntconversion