Update snackbar to use multiline overflow option#5730
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Mar 3, 2026
Merged
Update snackbar to use multiline overflow option#5730marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
rtibbles
approved these changes
Mar 3, 2026
Member
|
Hi @marcellamaki just a note that now all snackbars are with the same height. Can this fix be applied only to multiline snackbar messages maybe?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
In French and Portuguese, the "not relevant" recommendations snackbar string was too long to fit in it's container. We can use the Vuetify
multi-linprop for VSnackbar to manage this.References
Fixes #5407
Reviewer guidance
I forced this in the code jankily so I didn't have to do the fully CA local setup to test this fix. I think cross checking the code with the documentation and then asking QA team to confirm is probably easier than dev manual QA on this PR, unless you already have local testing for search recommendations set up.
before:

after:

AI usage
I asked Claude the easiest way to fix this and I learned this prop existed! handy!