Fixes file uploader showing invalid file modal just one time#5537
Conversation
438538c to
732c910
Compare
|
@MisRob I have rebased the branch onto the current unstable as you requested. On a side note, I’m currently deepening my understanding of the codebase, so if there are any medium to hard issues in future, please consider me for them I’d love to contribute 😊 |
|
Thanks @kart-u, occasionally there is a gap like now, but typically few new 'help wanted' issues of various complexity are added each week, so you can keep an eye on the list. |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks a lot @kart-u! This seems to be the right solution! However, it may be a bit tedious to maintain those different calls to the resetFileInput method, and if, for some reason, in the future, we have another modal, or if we add a @close event handler, we may forget to make this call to reset the input ref value.
What if we reset the fileUpload ref value after processing the files within the handleFiles method? That would make the solution a bit more flexible? Would like to know your thoughts!
|
@AlexVelezLl Sorry for the late reply I have exams going on, so my time was split. I also believe adding a reset in |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks a lot @kart-u!! This looks excellent! Merging 👐
Summary
Closes #5521
Due to the file input not being reset in
Uploader.vue, the modal exhibited buggy behavior where a alert modal for particular invalid file would only appear once when doing consecutive upload for the same file.This has been fixed by adding a
resetFileInput()call onKModalsubmitReferences
bandicam.2025-11-06.03-41-14-269.mp4
…
Reviewer guidance
…