[Remove Vuetify from Studio] Permanently delete resource confirmation dialog#5481
Conversation
|
Thanks you @z-ABYa, we will assign a reviewer next week. |
contentcuration/contentcuration/frontend/channelEdit/views/trash/TrashModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/trash/__tests__/trashModal.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/trash/__tests__/trashModal.spec.js
Outdated
Show resolved
Hide resolved
akolson
left a comment
There was a problem hiding this comment.
I also notice that we now conflicts, Could you please rebase to the latest unstable and resolve any conflicts therein? Thank you
|
@z-ABYa Thanks for the changes. LGTM! Could you also look into the merge conflicts as well? |
|
Sure @akolson. Sorry for the late reply, i was at a tech event for the last 2 days. |
| </KModal> | ||
| <MoveModal | ||
| v-else | ||
| v-if="moveModalOpen" |
There was a problem hiding this comment.
Hi @z-ABYa! Please revert this change to the previous code, it not only breaks the restore functionality, but is also outside the scope of the issue. Thanks!
There was a problem hiding this comment.
Hi @akolson, I have reverted to the previous code and made certain only the required changes are committed this time.
There was a problem hiding this comment.
I still think this in't reverted yet. v-if="moveModalOpen" should be replaced with v-else
fab996a to
81869de
Compare
| @@ -1,173 +1,170 @@ | |||
| <template> | |||
|
|
|||
| <div> | |||
There was a problem hiding this comment.
Let's revert this. And move the <MoveModal...> code to be a child of the div as previously. That way we keep the pr focused to the confirm dialog only. This will prevent potential regressions arising from moving around the code.
<template>
<div>
<FullscreenModal>
......
</FullscreenModal>
<MoveModal
v-else
.....
/>
</div>
</template>There was a problem hiding this comment.
Sure i'll make the required changes based on the structure you have suggested.
akolson
left a comment
There was a problem hiding this comment.
Hi @z-ABYa, great work on the migration.
It looks like the migration was actually completed earlier in this commit. However, your cleanup of the unused CSS is valuable and improves the codebase, so we’ll go ahead and merge this.
Feel free to shift your focus to the other issues assigned to you.
Thanks again for your contribution!
Fixes #5443
Summary
Previous (MessageDialogue)

After (KModal)
