When creating exercises, default randomize to true as data.#5427
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Oct 3, 2025
Merged
When creating exercises, default randomize to true as data.#5427marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
Remove UI only default.
marcellamaki
approved these changes
Oct 3, 2025
Member
marcellamaki
left a comment
There was a problem hiding this comment.
create an exercise ✅
imported and took it on Kolibri ✅
and the creation change for it is successfully synced and applied on the backend ✅
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we only defaulted the UI to show randomize as true for exercises. Somehow, because extra_fields was empty, this meant that we bypassed any validation at all, even though randomize used to be 'required'. In the most recent update, we made the validation more strict, and now it fails because it was not being set on initial exercise creation.
This resolves that by instead of just having a default displayed in the UI, the frontend sets randomize for any exercise node as true by default.
References
Fixes #5419
Reviewer guidance
Ensure you can create a new exercise and the creation change for it is successfully synced and applied on the backend.