[Remove Vuetify from Studio] Buttons / links on account created / deleted pages#5368
Conversation
MisRob
left a comment
There was a problem hiding this comment.
Thanks @yeshwanth235 for your continued contributions.
All looks good - just one note regarding the choice of a design system component.
| appearance="raised-button" | ||
| :primary="true" | ||
| :text="$tr('backToLogin')" | ||
| @click="$router.push({ name: 'Main' })" |
There was a problem hiding this comment.
Since the only purpose of clicking the button is to redirect, KRouterLink would be better fit
There was a problem hiding this comment.
You can also think about it from the perspective of semantic and accessible HTML markup - KRouterLink will render as <a> which is more appropriate here (compared to <button>).
|
Hi @yeshwanth235, I will be on vacation until September 22, so unless someone else merges your PR after you've resolved the feedback, I will get back to you as soon as I'm back. |
MisRob
left a comment
There was a problem hiding this comment.
Thank you @yeshwanth235, all works as expected.
Summary
Updated VBtn to Kbutton in Account Delete and Account Created pages
References
Closes 5353
Reviewer guidance
Test Kbuttons in Account Deleted and Account created pages.