Populate Country table#5168
Merged
AlexVelezLl merged 1 commit intolearningequality:community-channelsfrom Jul 11, 2025
Merged
Conversation
AlexVelezLl
reviewed
Jul 11, 2025
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks @Jakoma02! Looks good to me!
|
|
||
| def generate_list(self): | ||
| # Get constants from subclass' default_list (from le-utils pkg) | ||
| # Get constants from subclass' default_list (usually from le-utils pkg) |
AlexVelezLl
approved these changes
Jul 11, 2025
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thanks @Jakoma02! Merging
6894877
into
learningequality:community-channels
12 checks passed
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that
Countrymodel instances are created with country codes and names from ISO 3166-1 upon runningmake migrate.Detailed changes:
pycountrydependency for getting the list of countriespycountryto stay in sync with the country list in the frontendCountryGeneratorwas created, used to generate country constants, and added to the list of constantsThe changes were tested by running the
make migratecommand and checking that the countries table was populated in the database, particularly checking that Kosovo was present.References
Resolves #5158
Reviewer guidance
Apart from code review, running the
make migratecommand and checking that the country table got populated should be sufficient.