Issue#5123 : Migrated the offline alert bar in Settings from Vuetify to Kolibri Design System.#5162
Conversation
|
Thank you @AadarshM07, I will review soon. |
MisRob
left a comment
There was a problem hiding this comment.
Very nice work @AadarshM07! I successfully tested on multiple screen sizes, on both RTL and LTR, and with screen reader too. Thanks for following the guidance, much appreciated.
Leaving few notes, let me know what you think.
| icon="disconnected" | ||
| class="mx-3" | ||
| /> | ||
| <span class="notranslate">{{ $tr('offlineText') }}</span> |
There was a problem hiding this comment.
notranslate needs to be removed here - its only for texts that shouldn't be translated. Here we are translating.
There was a problem hiding this comment.
Sure, thanks for clarifying — I will remove it.
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Show resolved
Hide resolved
Co-authored-by: Michaela Robosova <robosovam@gmail.com>
There was a problem hiding this comment.
Thanks for resolving feedback @AadarshM07!
Two small styling changes and then we can merge.
Generally during this project, we don't want to introduce unexpected visual changes, even minor ones in padding and such.
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/views/StudioOfflineAlert.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Michaela Robosova <robosovam@gmail.com>
Co-authored-by: Michaela Robosova <robosovam@gmail.com>
|
I’ve made the necessary updates - thank you for the guidance👍 |
Summary
Migrated the OfflineText Vuetify component with a new StudioOfflineAlert component that uses Kolibri Design System by following the guidelines .
KDS components used:
Manual verification steps performed:
UI screenshots:
Desktop:
Mobile:
References
Reviewer guidance