Migrate kradiobutton usages#4889
Conversation
AlexVelezLl
left a comment
There was a problem hiding this comment.
Hi @akolson! I just found a little bug in the LanguageSwitcherModal, everything else looks good to me 👐.
| :title="language.english_name" | ||
| class="language-name" | ||
| /> | ||
| <KRadioButtonGroup> |
There was a problem hiding this comment.
In general here I think we are managing these columns a little bit strange 😅 because on top of this we are using a grid item to render the number of columns, and for each colum we render the languages radio buttons, that means that if we add the KRadioButtonGroup inside the grid item the up and down arrows will just work for one column and not the other.
Compartir.pantalla.-.2025-02-06.09_31_02.mp4
Since KRadioButton should be a direct child of KRadioButtonGroup, I think we should refactor how we manage the column rendering to avoid having two different divs for different columns. I think grid or flex layouts would help here :) Nvm just checked it and it seems that KRadioButtonGroup does work with nested children, so we can just wrap the KGridItems with KRadioButtonGroup just as we do in Kolibri!
AlexVelezLl
left a comment
There was a problem hiding this comment.
Its now working fine. Thanks @akolson!
Summary
This pr wraps the
KRadioButtonGrouparound theKRadioButtonas specified in the design docs. It also migrates theKRadioButtonto use thebuttonValueover the deprecatedvalueprop.References
Closes #4869
Reviewer guidance
/settings/#/storage)KRadioButton#4869