Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 0 additions & 84 deletions .github/pull_request_template.md

This file was deleted.

1 change: 1 addition & 0 deletions docs/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- [Local development tools](./dev_tools.md)
- [Running tests](./running_tests.md)
- [Adding or updating dependencies](./dependencies.md)
- [Preparing a pull request](../pull_requests.md)

## Additional development tools

Expand Down
16 changes: 16 additions & 0 deletions docs/pull_requests.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
Preparing a pull request
=============

Before opening or approving a PR, consider:

Security and privacy:
- If there new ways this uses user data that needs to be factored into our [Privacy Policy](https://github.com/learningequality/studio/tree/master/contentcuration/contentcuration/templates/policies/text), it has been noted.


Internationalization:
- All user-facing strings are translated properly
- The `notranslate` class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
- All UI components are LTR and RTL compliant

Deployment:
- Migrations are [safe for a large db](https://www.braintreepayments.com/blog/safe-operations-for-high-volume-postgresql/)