Properly format node_id+channel_id query parameter#4530
Merged
bjester merged 2 commits intolearningequality:hotfixesfrom Apr 23, 2024
Merged
Properly format node_id+channel_id query parameter#4530bjester merged 2 commits intolearningequality:hotfixesfrom
bjester merged 2 commits intolearningequality:hotfixesfrom
Conversation
AlexVelezLl
approved these changes
Apr 23, 2024
Member
AlexVelezLl
left a comment
There was a problem hiding this comment.
Looks good to me, I runned the code and confirmed that now clipboard is working fine!
rtibbles
approved these changes
Apr 23, 2024
Member
rtibbles
left a comment
There was a problem hiding this comment.
I opened this PR, nodded sagely, and thought "this makes sense", then forgot to leave a review, so I'll pile on here!
Member
Author
|
Thanks all! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
getByNodeIdChannelIdto use proper format for the query parameter[node_id+channel_id]__infilteringManual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
Follow the above steps
Are there any risky areas that deserve extra testing?
I did update some clipboard actions that seemed to be passing a flattened array for
__inqueryReferences
Fixes #4508
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)