Removed BottomToolBar with BottomBar#4359
Closed
cerdo03 wants to merge 1 commit intolearningequality:unstablefrom
Closed
Removed BottomToolBar with BottomBar#4359cerdo03 wants to merge 1 commit intolearningequality:unstablefrom
cerdo03 wants to merge 1 commit intolearningequality:unstablefrom
Conversation
AlexVelezLl
requested changes
Dec 29, 2023
| </VFlex> | ||
| </VLayout> | ||
| <BottomToolBar | ||
| <BottomBar |
Member
There was a problem hiding this comment.
Hi! @cerdo03. We need to be careful because the implementation of BottomToolBar and BottomBar are slightly different, for example BottomBar does not recieve any props, but BottomToolBar does. So all places where BottomToolBar receives props are likely to have errors. I let you an example for the CalatogList component:
The views should remain the same after the change to avoid unintended behaviours.
| <slot></slot> | ||
| </VContainer> | ||
| <BottomToolBar v-if="$slots.bottom" color="white" flat clipped-left clipped-right> | ||
| <BottomBar v-if="$slots.bottom" color="white" flat clipped-left clipped-right> |
Member
24 tasks
Member
|
Hi! @cerdo03 Hope you are doing fine. Just a friendly reminder that this PR is still open, do you plan to continue working on it? Or we can close it and assign the issue to someone else? |
Member
|
Closing due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary
Description of the change(s) you made
Fixes #2008
I have replaced all occurences of BottomToolBar with Bottombar. Modified the import statements accordingly.
Reviewer guidance
How can a reviewer test these changes?
References
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)