Fixes incorrect value for Practice quiz

[akolson]

Summary

Description of the change(s) you made

This pr fixes the incorrect value displayed when Practice quiz is selected as the Completion type for a new Exercise.

Manual verification steps performed

1. Sign in to Studio and open a channel
2. Create an exercise and set the Completion to Practice quiz.
3. The resource metadata window show Practice quiz as Completion value.
4. Edit the completion process to another type and that no regressions are present

Screenshots (if applicable)

Screen.Recording.2023-08-22.at.15.11.30.mov

Does this introduce any tech-debt items?

No

---

Reviewer guidance

How can a reviewer test these changes?

After setting up the project's development dependencies, and ensuring that Studio is running locally;

1. Sign in to Studio and open a channel
2. Create an exercise and set the Completion to Practice quiz.
3. The resource metadata window show Practice quiz as Completion value.
4. Edit the completion process to another type and that no regressions are present

Are there any risky areas that deserve extra testing?

Not really, but ensuring the changes made have not broken the behavior of the other Completion types.

References

Fixes #4215

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[marcellamaki]

Looks good @akolson - I love the changed you made that clean up some of the constants to better managed the completion criteria models!

So as to make best use of @pcenov's time, I'm going to go ahead and merge this, as I've confirmed the fix, and then have Peter do the regression testing that he will be doing as part of the QA process for hotfixes for the upcoming studio release (probably next week), rather than having him do it twice. cc @radinamatic

[pcenov]

Implemented as specified, no regressions observed while manually testing.