Prevent errors when creating already existing tag through model entries.#4232
Merged
rtibbles merged 2 commits intolearningequality:hotfixesfrom Jul 19, 2023
Merged
Prevent errors when creating already existing tag through model entries.#4232rtibbles merged 2 commits intolearningequality:hotfixesfrom
rtibbles merged 2 commits intolearningequality:hotfixesfrom
Conversation
bjester
approved these changes
Jul 19, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
Followed up on Slack about missing tags despite the error, but this looks good nevertheless
| # rtibbles: For reasons I have not been able to discern, under certain circumstances | ||
| # these mappings can already exist in the database. This is a workaround to prevent | ||
| # this from breaking copying. | ||
| self.model.tags.through.objects.bulk_create(mappings_to_create, ignore_conflicts=True) |
Member
There was a problem hiding this comment.
Thank goodness for ignore_conflicts!
Member
Author
|
Have done a bit more investigation here, and I now think I know why this has happened and can write a regression test for it, so will push another commit with that. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
ignore_conflicts=Truewhen bulk creating Tag through objects to prevent errors from duplicated entries which break copying, but are not an issue.Manual verification steps performed
I couldn't reproduce this so went for the minimal fix - as long as the Python tests pass, I think this is adequately covered by automated tests.
References
Fixes #4221
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)