Fix broken 'Go to location' link in Import Search#4175
Merged
bjester merged 1 commit intolearningequality:hotfixesfrom Jun 26, 2023
Merged
Fix broken 'Go to location' link in Import Search#4175bjester merged 1 commit intolearningequality:hotfixesfrom
bjester merged 1 commit intolearningequality:hotfixesfrom
Conversation
marcellamaki
approved these changes
Jun 23, 2023
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Looks good to me - seems to fix in the UI. I'm not sure if the order should be considered a blocking change here, and whether or not that is connected to this specific fix. If that can be resolved separately, I think this is okay to merge
| node_id: 'id', | ||
| content_id: 'content_id', | ||
| channel_id: 'channel_id', | ||
| parent: 'parent', |
Member
There was a problem hiding this comment.
why is this deleted here? this is a curious question not an implication that "it shouldn't be" :)
Member
Author
There was a problem hiding this comment.
By removing this from the map, it prevents the parent from being overwritten in convertContentNodeResponse, because it's now manually being set.
This was referenced Jul 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
parentwhen converting from public node format to Studio's IDsManual verification steps performed
Does this introduce any tech-debt items?
It appears the search results are rendering in an order that is different than what is returned from the server.
References
Fixes: #4168
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)