Skip to content

Fix issue parsing object as JSON string#4140

Closed
bjester wants to merge 4 commits intolearningequality:hotfixesfrom
bjester:fix-json-issue
Closed

Fix issue parsing object as JSON string#4140
bjester wants to merge 4 commits intolearningequality:hotfixesfrom
bjester:fix-json-issue

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Jun 14, 2023

Summary

Description of the change(s) you made

  • The public contentnode API sometimes returns an object {} for options, and other times a JSON string "{}" -- this adds defensive checks against that
  • Rendering topics in search failed without resource_count
  • Changes page size options to reduce likelihood of failed searches
  • Changes default page size to 15 instead of 25
  • Enforces page size is one of available options
  • Adds hacks if we fail to side-load some nodes
  • Only loads published nodes when browsing (not searching) through public channels

Manual verification steps performed

  1. I manually edited fetchResourceSearchResults Vuex action to use same search API response as on hotfixes
  2. I manually edited the public ContentNodeViewset to proxy requests to hotfixes
  3. I observed the JSON issue hidden without Sentry reporting
  4. Made other changes and verified things still worked locally

Does this introduce any tech-debt items?

The hacky side-loading logic


Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

#4137 (comment)

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant