Fixes loading spinner issue#4099
Merged
bjester merged 2 commits intolearningequality:unstablefrom May 31, 2023
Merged
Conversation
bjester
approved these changes
May 31, 2023
Member
bjester
left a comment
There was a problem hiding this comment.
Nice work! It does indeed show something other than the loading spinner
Although, since the search API doesn't return all pertinent info about the node, the details are inaccurate. I'll write up a followup issue for that, since that is more likely a P1 that we can fix later.
Member
|
There was one unrelated issue that I saw when trying to complete the import of a node I previewed and added from the side panel. I think it's best to merge this and verify it in conjunction with Richard's change event updates on the unstable server. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr fixes the continuous loading spinner when previewing a searched channel resource.
Manual verification steps performed
Reviewer guidance
How can a reviewer test these changes?
References
Fixes #3956
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)