Factor in language when counting distinct content items#4057
Merged
Factor in language when counting distinct content items#4057
Conversation
This bumps us up from 147K to almost 190K distinct content items in the public library.
Member
Author
|
(this isn't urgent, as I was able to get the counts manually) |
bjester
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Ideally, we want the "same" piece of content across multiple languages to have distinct content_ids, so that progress isn't shared etc. We already knew this wasn't the case for Khan Academy channels, for legacy reasons, but it turns out there are other channels in the same boat. This PR calculates uniqueness when counting items in the library as a combination of content_id and language_id.
This bumps the count up from 147K to almost 190K distinct content items in the public library.
Manual verification steps performed
Contributor's Checklist
Testing:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)