Skip to content

Factor in language when counting distinct content items#4057

Merged
bjester merged 1 commit intounstablefrom
jamalex-patch-1
May 4, 2023
Merged

Factor in language when counting distinct content items#4057
bjester merged 1 commit intounstablefrom
jamalex-patch-1

Conversation

@jamalex
Copy link
Copy Markdown
Member

@jamalex jamalex commented May 4, 2023

Summary

Description of the change(s) you made

Ideally, we want the "same" piece of content across multiple languages to have distinct content_ids, so that progress isn't shared etc. We already knew this wasn't the case for Khan Academy channels, for legacy reasons, but it turns out there are other channels in the same boat. This PR calculates uniqueness when counting items in the library as a combination of content_id and language_id.

This bumps the count up from 147K to almost 190K distinct content items in the public library.

Manual verification steps performed

  1. Tested out management command and ensured the numbers all made sense

Contributor's Checklist

Testing:

  • Contributor has fully tested the PR manually

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

This bumps us up from 147K to almost 190K distinct content items in the public library.
@jamalex
Copy link
Copy Markdown
Member Author

jamalex commented May 4, 2023

(this isn't urgent, as I was able to get the counts manually)

@bjester bjester merged commit e888611 into unstable May 4, 2023
@rtibbles rtibbles deleted the jamalex-patch-1 branch October 6, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants