Fix production task-related issues and issue logging out#3934
Merged
rtibbles merged 4 commits intolearningequality:hotfixesfrom Feb 2, 2023
Merged
Fix production task-related issues and issue logging out#3934rtibbles merged 4 commits intolearningequality:hotfixesfrom
rtibbles merged 4 commits intolearningequality:hotfixesfrom
Conversation
…ts and reorganize existing
…me delay for logging out
rtibbles
approved these changes
Feb 2, 2023
| return syncChanges(); | ||
| } | ||
| // TODO: actually return promise that resolves when active sync completes | ||
| return new Promise(resolve => setTimeout(resolve, 1000)); |
Member
There was a problem hiding this comment.
We may be able to use the p-debounce library for this in future, or vendor and modify it like I have here: https://github.com/learningequality/kolibri/blob/develop/kolibri/plugins/learn/assets/src/composables/useProgressTracking.js#L474
Member
Author
There was a problem hiding this comment.
Prathamesh and I have been integrating streams into this sync code for websockets, which eliminates this syncActive state management and will make it easier to determine when it's complete.
This was referenced Feb 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
get_node_diffendpointsignatureon task resultManual verification steps performed
Screenshots (if applicable)
Does this introduce any tech-debt items?
Yes, the changes to resolve the issue with
forceServerSyncwill need refactoring to return a promise that resolves when the sync is actually complete, for the use case of when that function is called during signout. With the upcomingwebsocketintegration, we should be able to resolve it since we're restructuring how we handle data syncing.References
Resolves #3931
Resolves #3921
Resolves #3836
Resolves #3925
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)