fixed focus on navigation through the navigation drawer

[AllanOXDi]

Summary

This PR fixes hidden focus navigation when using the tab key.

Fixes #3786

Screenshots (if applicable)

screen-capture.3.mp4

Reviewer guidance

How can a reviewer test these changes?

Step 1:Navigate the menu using the tab key when the navigation drawer is open.Try it again when the drawer is closed.

References

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[radinamatic]

@AllanOXDi From viewing the included video alone, there is one thing missing here: the visual focus outline of the button that opens the user menu, and the NEW CHANNEL button 🙂

Both are in the Tab order and should have the outline focus 'ring', but we clearly see the gap after the focus moves from the COLLECTIONS tab, and until it lands on the Empty channel card.

[AllanOXDi]

Okay! Let me try to replicate that behaviour.

[LianaHarris360]

The button that opens the user menu and the NEW CHANNEL button now have the expected outline focus 'ring'

OutlineFocusRingOnButtons.mov

[bjester]

Nice work, team!