Ensure changes get properly cleared as succeeded and make refresh blocking more targeted#3789
Merged
rtibbles merged 3 commits intolearningequality:hotfixesfrom Nov 3, 2022
Merged
Conversation
Do explicit checks for unapplied revs.
…her changes are still processing.
bjester
reviewed
Nov 3, 2022
contentcuration/contentcuration/frontend/shared/data/resources.js
Outdated
Show resolved
Hide resolved
bjester
requested changes
Nov 3, 2022
Member
bjester
left a comment
There was a problem hiding this comment.
I tested moving items to trash and copying multiple folders as described, and it all looks good. Requested changes are:
- updating
params.idstoparams.id__inas mentioned - perhaps adding
|| params.parent === c.key-- creating a new folder and immediately opening it is failing
Member
Author
|
Will update, thanks for the tests and the eyes on code! |
Correct ids to id__in.
Member
Author
|
Updated! |
bjester
approved these changes
Nov 3, 2022
Member
bjester
left a comment
There was a problem hiding this comment.
Changes look good and testing too. One thing I noticed, and can add a followup issue for, is that trying to upload files to a new folder not yet created on the backend ends up failing silently. Looks like it's making a request to fetch the folder content node. We probably want to put some similar checks in the Resource.get method
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
_clone_nodemethod of theCustomContentNodeTreeManagerto make copies run slowly to replicate the error from productionimport from channelsmodal, to ensure two copy operations are startedScreenshots (if applicable)
Screencast.from.11-02-2022.02.54.48.PM.webm.mp4
Does this introduce any tech-debt items?
I think this can be done much more neatly and efficiently with the websockets work!
Reviewer guidance
How can a reviewer test these changes?
Do the manual steps suggested above.
Review the new logic for more targeted refresh blocking - does this miss any cases?
References
Fixes #3753