Stop using the google storage API url in production to prevent CORS issues#3768
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Oct 25, 2022
Merged
Conversation
aronasorman
approved these changes
Oct 24, 2022
Collaborator
aronasorman
left a comment
There was a problem hiding this comment.
change looks about right
Member
|
@rtibbles this has fixed the thumbnail generation issue for all resources except for the EPUB:
|
Member
Author
|
Interesting - that looks like a completely different error! |
Member
Author
|
Filed a follow up here: #3770 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
References
Fixes #3764