Allow determined by resource to be stored as a value.#3767
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Oct 24, 2022
Merged
Allow determined by resource to be stored as a value.#3767marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
marcellamaki
approved these changes
Oct 24, 2022
Member
marcellamaki
left a comment
There was a problem hiding this comment.
Looks good to me.
@pcenov and @radinamatic - I think some of the bugs that you reported will build on this but are not solved by this, (thinking especially of some of the validation errors and display combinations) so just flagging to both of you that I'll be making a PR after this is merged, hopefully tomorrow, and 🤞 that is gets those last completion/duration weirdness settings resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
determined_by_resourceas a valid completion criterion.Manual verification steps performed
Screenshots (if applicable)
References
Fixes #3750
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)