Skip to content

Resolve RTL dropdown issues #3756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcellamaki merged 2 commits into from
Oct 20, 2022
Merged

Resolve RTL dropdown issues #3756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
704285d
Resolve RTL dropdown issues
bjester Oct 19, 2022
69264f0
Return empty string for class instead of null
bjester Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion contentcuration/contentcuration/frontend/channelEdit/components/edit/CategoryOptions.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@
},
methods: {
treeItemStyle(item) {
return this.nested ? { paddingLeft: `${item.level * 24}px` } : {};
const rule = this.$isRTL ? 'paddingRight' : 'paddingLeft';
return this.nested ? { [rule]: `${item.level * 24}px` } : {};
},
add(value) {
this.selected = [...this.selected, value];
Expand Down
14 changes: 14 additions & 0 deletions contentcuration/contentcuration/frontend/shared/views/form/DropdownWrapper.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
top: this.top,
maxHeight: this.menuHeight,
lazy: true,
contentClass: this.$isRTL ? 'forceRTLMenu' : '',
};
},
},
Expand Down Expand Up @@ -91,3 +92,16 @@
};

</script>
<style>

/* According to the documentation, Vuetify supposedly supports a `right` prop to position the menu
on the right side, but there isn't any code that actually does this. So when using an RTL
language, this class will be applied and these will get flipped, because our intention is
left:auto and right:0
*/
.forceRTLMenu {
left: 0 !important;
right: auto !important;
}

</style>