Skip to content

Fix i18n induced issues with learning activity icons.#3749

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:i18nicons
Oct 19, 2022
Merged

Fix i18n induced issues with learning activity icons.#3749
bjester merged 1 commit intolearningequality:hotfixesfrom
rtibbles:i18nicons

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Update tree view to include new metadata #3344 inadvertently used translated strings to select the appropriate learning activity icon
  • This went undetected until we actually had translations in place, so for non-English languages this broke
  • This fixes this by removing the translation step from the icon selection

Manual verification steps performed

  1. Switch to a non-English interface language
  2. Look at the tree view for items with learning activities assigned
  3. See them displayed properly

Updated behaviour to fix automated tests also.

Screenshots (if applicable)

Screenshot from 2022-10-18 16-21-48

References

Fixes #3748

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bjester bjester merged commit 21a778b into learningequality:hotfixes Oct 19, 2022
@radinamatic
Copy link
Copy Markdown
Member

Is this deployed to hotfixes Studio already? Because I'm not seeing any change when browsing in non English UI... 😕

Cleared cache and all site data, but no dice.

learning-activity-icons.mp4

@bjester
Copy link
Copy Markdown
Member

bjester commented Oct 20, 2022

@radinamatic Looks like the build failed. I've restarted it

@radinamatic
Copy link
Copy Markdown
Member

Icons are back in non-English Studio UI! 🎉 🎉 🎉 🎉 🎉

Selection_050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants