Skip to content

Add channel link to the channel published email#3737

Merged
rtibbles merged 2 commits intolearningequality:unstablefrom
vkWeb:email/published_channel
Nov 1, 2022
Merged

Add channel link to the channel published email#3737
rtibbles merged 2 commits intolearningequality:unstablefrom
vkWeb:email/published_channel

Conversation

@vkWeb
Copy link
Copy Markdown
Member

@vkWeb vkWeb commented Oct 14, 2022

Summary

This PR adds the published channel link to the channel published email template.

Screenshots (if applicable)

This is how the email looks after it gets rendered:

Screenshot from 2022-10-14 15-59-55


Reviewer guidance

You can run the publish_channel function from the terminal via devshell to look at the email in stdout. Does the email output looks correct?

References

Closes #3560.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@vkWeb vkWeb requested review from bjester and rtibbles October 15, 2022 07:40
@vkWeb vkWeb requested a review from rtibbles October 31, 2022 12:28
@rtibbles rtibbles merged commit 172eb66 into learningequality:unstable Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a link to the channel in the channel publish email

2 participants