Skip to content

Reset new/updated descendant flags on publish#3732

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:publish-status
Oct 12, 2022
Merged

Reset new/updated descendant flags on publish#3732
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:publish-status

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Oct 12, 2022

Summary

Description of the change(s) you made

The logic for determining whether a folder has new or updated descendants checks the children's status on whether it has changed, or has new/updated descendants if it's a folder. In the case when not all descendants haven't been loaded into the frontend, the logic may not properly represent a folder's published state. This PR updates the publish logic to not only mark all nodes as published, but to also reset the has_new_descendants and has_updated_descendants flags.

Manual verification steps performed

  1. Create a new channel
  2. Add a folder Folder A and a resource to the channel root
  3. Add 2 more levels of folders inside Folder A, B inside A, and C inside B
  4. Finally, upload a resource to Folder C
  5. Sign out of Studio
  6. Sign back in and open the channel -- don't browse anything
  7. Immediately publish the channel
  8. Observe the publish status on Folder A and the adjacent resource updates correctly
  9. Update the resource in Folder C
  10. Sign out of Studio
  11. Sign back in and open the channel -- don't browse anything
  12. Immediately publish the channel
  13. Observe the publish status on Folder A updates correctly

References

Fixes #3512

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from rtibbles October 12, 2022 18:10
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - I am glad this was this simple! Will test.

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants