Reset new/updated descendant flags on publish#3732
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Oct 12, 2022
Merged
Reset new/updated descendant flags on publish#3732rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
rtibbles
reviewed
Oct 12, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Nice - I am glad this was this simple! Will test.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
The logic for determining whether a folder has new or updated descendants checks the children's status on whether it has changed, or has new/updated descendants if it's a folder. In the case when not all descendants haven't been loaded into the frontend, the logic may not properly represent a folder's published state. This PR updates the publish logic to not only mark all nodes as published, but to also reset the
has_new_descendantsandhas_updated_descendantsflags.Manual verification steps performed
Folder Aand a resource to the channel rootFolder A,BinsideA, andCinsideBFolder CFolder Aand the adjacent resource updates correctlyFolder CFolder Aupdates correctlyReferences
Fixes #3512
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)