Remove feature flag for channel quizzes, thus fixing completion/duration dropdowns

[marcellamaki]

Summary

Description of the change(s) you made

This PR removes the channel quiz/practice quiz feature flag, based on a conversation with Richard. This feature was causing complications in the edit modal around completion and duration options.

Manual verification steps performed

1. Sign in as a non-admin
2. Add or edit a contentNode, opening the Edit Modal
3. The completion option should be available, for all content types

---

Reviewer guidance

How can a reviewer test these changes?

See above

Comments

Are the of the right UI options available for all exercises now? 🤔 I'm not actually 100% sure

References

#3705 (comment)

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[rtibbles]

Checked with both admin and non-admin users. Only slight possible issue here is users not understanding what a practice quiz is - but we can address that later.

[pcenov]

Hi @marcellamaki, when creating an exercise if I go ahead and select Practice quiz in the Completion drop-down without having specified the Goal value beforehand then the time values in minutes are not being displayed at all for any of the Duration options and it complains that the resource is incomplete. I have to set the Goal value in order to get the Minutes drop-down displayed:

2022-10-19_15-42-30.mp4

I've filed separately a possibly related issue: #3751

[marcellamaki]

Thanks @pcenov -- I'll take a look at this, and then take a look at the other issue you mention as well!

[radinamatic]

My testing with completion on exercises was also bumpy, but may be related to this, so I'll expose it here unless you prefer a completely new issue.

1. Import an exercise from another channel.
2. Open the edit modal and go to completion section.
3. Change to Practice quiz type, instead of the default When goal is met, and you see the Duration field appear as required.
4. Revert to When goal is met (because Practice quiz is not what you want), goal options are there again, but so is the Duration field, marked in red as required.
5. Save and finish (Studio is not counting that missing duration as incomplete).
6. Reopen the edit modal for the same exercise, and now you see the When goal is met but without any of the goal options, but with the Duration field not set.
7. Sign out and sign in again, and now you see the When goal is met with all of the goal options there again.

Very confusing and inconsistent, but my main qualm is the presence of the Duration field, as to me completion of type When goal is met goes against setting a duration for the resource... 🤔 It's either goal accomplished by the number of required correct answers in an exercise, or by duration... During which the number of correct answers does not count?

completion-objective-reached.mp4

cc @marcellamaki