Skip to content

Fix metadata 'level' labeling#3704

Merged
bjester merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:fix-metadata-labels
Sep 30, 2022
Merged

Fix metadata 'level' labeling#3704
bjester merged 1 commit intolearningequality:hotfixesfrom
marcellamaki:fix-metadata-labels

Conversation

@marcellamaki
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki commented Sep 30, 2022

Summary

Description of the change(s) you made

Adds necessary conditions (due to a mis-match of strings/mapping) to ensure that all string references are able to be translated on the Resource Panel as well as on the display chips

Fixes #3664

Manual verification steps performed

  1. Add a resource
  2. Add all levels to the resource - ensuring accurate display in the dropdown and in the chips within the form
  3. Save and exit. Check the display in the comfortable/default view on the main channel page to ensure chips are displaying strings accurately
  4. Open the side panel and ensure that the strings are displaying correctly for all levels there.

Screenshots (if applicable)

Screen Shot 2022-09-30 at 9 08 48 AM

Screen Shot 2022-09-30 at 9 09 03 AM

Screen Shot 2022-09-30 at 9 09 11 AM

Does this introduce any tech-debt items?

This does not add any new tech-debt, but it also doesn't resolve the strings problem, which should probably be revisited. The translation logic in general for all of the metadata work is replicated in a lot of places at this point, and could probably be refactored or otherwise cleaned up.


Reviewer guidance

How can a reviewer test these changes?

See manual verification steps above


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

…y accurately on chips and in the Resource panel
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit 0e22f28 into learningequality:hotfixes Sep 30, 2022
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Oct 3, 2022

Confirmed as fixed at Hotfixes.

@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants