Tweaks to channel ordering for import from channels#3702
Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom Oct 3, 2022
Merged
Tweaks to channel ordering for import from channels#3702marcellamaki merged 1 commit intolearningequality:hotfixesfrom
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
Conversation
Adds and uses custom ordering for import fetches.
marcellamaki
approved these changes
Oct 3, 2022
Member
marcellamaki
left a comment
There was a problem hiding this comment.
This looks good. Tested all scenarios and working as expected.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
Screenshots (if applicable)
My channels - last modified sort:

Content library - name sort:

My channels page - last modified sort:

Content Library - name sort:

Does this introduce any tech-debt items?
Might want to come back and cleanup how we are handling ordering slightly - Kolibri handles it a bit better, and leaning on that would allow us to sort by multiple fields from the frontend.
References
Makes updates suggested here: #3592 (comment)