Skip to content

Tweaks to channel ordering for import from channels#3702

Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
rtibbles:ordah_ordah
Oct 3, 2022
Merged

Tweaks to channel ordering for import from channels#3702
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
rtibbles:ordah_ordah

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Sets a default ordering on the channel endpoint.
  • Adds and uses custom ordering for import fetches.

Manual verification steps performed

  1. Check ordering on import from channels for content library - should be sorted by name
  2. Check ordering on import from channels for 'my channels' - should be sorted by last modified
  3. Check ordering on channel list pages that this has not changed

Screenshots (if applicable)

My channels - last modified sort:
Screenshot from 2022-09-29 16-56-28

Content library - name sort:
Screenshot from 2022-09-29 16-57-29

My channels page - last modified sort:
image

Content Library - name sort:
image

Does this introduce any tech-debt items?

Might want to come back and cleanup how we are handling ordering slightly - Kolibri handles it a bit better, and leaning on that would allow us to sort by multiple fields from the frontend.

References

Makes updates suggested here: #3592 (comment)

Adds and uses custom ordering for import fetches.
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Tested all scenarios and working as expected.

@marcellamaki marcellamaki merged commit 98f38d8 into learningequality:hotfixes Oct 3, 2022
@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants