Minimal fix for duplicate tags for null channel errors#3701
Merged
bjester merged 5 commits intolearningequality:hotfixesfrom Sep 30, 2022
Merged
Minimal fix for duplicate tags for null channel errors#3701bjester merged 5 commits intolearningequality:hotfixesfrom
bjester merged 5 commits intolearningequality:hotfixesfrom
Conversation
0bf5231 to
10f4e34
Compare
bjester
approved these changes
Sep 30, 2022
Member
|
@rtibbles none of the newly added fields such as Learning Activity, Level, Requirements and Category are being synced - is this intentional or an oversight? |
Member
Author
|
This is an oversight - I'll need to make some updates to ensure these get synced. |
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
get_or_createas will error out when there are multiple ContentTag objects for the sametag_nameand null channel combinationoriginal_channel_idon a ContentNode during the copy operation on the frontendManual verification steps performed
./contentcuration/manage.py shell) create a tag with the sametag_namepropertyTagsto syncFor the copy bug, this replicates by doing the following:
Fixes #3690
Fixes other undocumented bugs.