Skip to content

Do existence check on navigator.clipboard#3698

Merged
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
rtibbles:clipboard_context
Sep 30, 2022
Merged

Do existence check on navigator.clipboard#3698
marcellamaki merged 1 commit intolearningequality:hotfixesfrom
rtibbles:clipboard_context

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Adds existence checks everywhere that navigator.clipboard is referenced
  • Hides copy buttons and prevents the clipboard being used

Manual verification steps performed

  1. Checked that token copying still works in admin and non-admin

References

Fixes #3637

@rtibbles rtibbles requested review from bjester and marcellamaki and removed request for bjester September 29, 2022 01:55
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Code makes sense, checked to ensure token copying still works, and also did a check with clipboardAvailable() manually set to false for copying from the token model and it is prevented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants