Update IndexedDB mutations#3687
Merged
bjester merged 5 commits intolearningequality:hotfixesfrom Sep 29, 2022
Merged
Conversation
…tive updates for new properties. Fix assessment item change application. Make the fileUploadsMap the source of truth.
bjester
reviewed
Sep 28, 2022
contentcuration/contentcuration/frontend/shared/vuex/channel/mutations.js
Outdated
Show resolved
Hide resolved
Update mutations to use Vue.set.
bjester
approved these changes
Sep 29, 2022
| setTasks(tasks) { | ||
| for (let task of tasks) { | ||
| // Coerce channel_id to be a simple hex string | ||
| task.channel_id = task.channel_id.replace('-', ''); |
Member
There was a problem hiding this comment.
Could probably remove the - replacement here with this change
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
-separated uuid for easier cross referenceapplyModsand uses the version fromapplyRemoteChangescontentnode,assessment_idid keyManual verification steps performed
Primarily tested this to ensure publishing was working as intended.
Screencast.from.09-27-2022.04.21.11.PM.webm.mp4
Automated test coverage for the file vuex module give me confidence about those changes.
Are there any risky areas that deserve extra testing?
Once this is merged, we should probably do another quick pass to ensure that all collaborative edits are showing up as intended.
References
Fixes #3683