Skip to content

Resolve issues affecting the bulk editing of new metadata fields#3670

Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:bulk-metadata-editing
Sep 23, 2022
Merged

Resolve issues affecting the bulk editing of new metadata fields#3670
rtibbles merged 1 commit intolearningequality:hotfixesfrom
bjester:bulk-metadata-editing

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Sep 23, 2022

Summary

Description of the change(s) you made

Refactors the helper that defines the getter for nested object fields, used for the new metadata, so that it extracts the object keys during the mapping of nodes, and produces the intersection of those values between all selected nodes

Manual verification steps performed

  1. Opened a channel for editing
  2. Selected multiple nodes
  3. Set metadata fields
  4. Finish editing
  5. Verified metadata was appropriately saved
  6. Open only one of the selected resources for editing
  7. Verify the previously set metadata is shown
  8. Make further edits to the single node's metadata
  9. Verified metadata was appropriately saved

References

Fixes #3663


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, and fix works as described.

@rtibbles rtibbles merged commit fbe6016 into learningequality:hotfixes Sep 23, 2022
@bjester bjester mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants