Skip to content

Hide tooltip for certain accessibility options and reorder them#3649

Merged
bjester merged 3 commits intolearningequality:unstablefrom
bjester:accessibility-tooltips
Sep 19, 2022
Merged

Hide tooltip for certain accessibility options and reorder them#3649
bjester merged 3 commits intolearningequality:unstablefrom
bjester:accessibility-tooltips

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Sep 16, 2022

Summary

Description of the change(s) you made

@thanksameeelian and I cohacked on this

  • Hides the tooltip for the "Has captions or subtitles" accessibility option since it's self-explanatory
  • Reorder the accessibility options so that "Has captions or subtitles" is first

Manual verification steps performed

  1. Clicked to 'Edit details' a video resource
  2. Verified that the tooltip info icon does not show for the option
  3. Verified that the option is first

Screenshots (if applicable)

Screenshot from 2022-09-16 09-06-19


Reviewer guidance

References

Fixes #3610

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester merged commit 99db2a2 into learningequality:unstable Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants