Skip to content

Use the file format as the default extension in case the passed in name for the file does not have one.#3646

Merged
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:file_format
Sep 16, 2022
Merged

Use the file format as the default extension in case the passed in name for the file does not have one.#3646
bjester merged 1 commit intolearningequality:unstablefrom
rtibbles:file_format

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Fixes small edge case that was showing up for graphie file uploads in ricecooker
  • The graphie files' original filename had no extension, so the files were being uploaded to the checksum with no file extension, and then seemed to have not been uploaded.
  • This uses the supplied file_format as the default extension to prevent this.

@rtibbles rtibbles requested a review from bjester September 16, 2022 00:16
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the generate_object_storage_name source, and this looks good to me.

@bjester bjester merged commit 605106a into learningequality:unstable Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants