Skip to content

Fixes relaying of copy/move changes with refactoring#3640

Merged
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:relay-changes
Sep 15, 2022
Merged

Fixes relaying of copy/move changes with refactoring#3640
rtibbles merged 1 commit intolearningequality:unstablefrom
bjester:relay-changes

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Sep 14, 2022

Summary

Description of the change(s) you made

  • Copy and move changes would fail to be applied when relayed to other editors/browsers
  • Refactors transaction handling to open a transaction when applying each type of change
    • This is likely slower but allows finer grained transaction management on per-change basis

Manual verification steps performed

  1. Open two separate browsers
  2. Sign into Studio on each browser
  3. Open the same channel in each browser
  4. In one browser, duplicate a resource
  5. In the other browser, watch for the duplicate to appear-- it should

Does this introduce any tech-debt items?

To wrap up parallel websocket integration work, we may want to consider implementing a FIFO queue when receiving changes or other updates over the websocket before passing along to applyChanges


Reviewer guidance

References

Fixes #3635

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense - will manually test.

Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested with both copies and moves, changes seem to replicate as intended.

@rtibbles rtibbles merged commit 3f596a8 into learningequality:unstable Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fronted not being updated for a copy change from another collaborative user

2 participants