Updates width of content library channel cards with no description to…#3639
Merged
bjester merged 3 commits intolearningequality:unstablefrom Sep 16, 2022
Merged
Conversation
… fill horizontal space
bjester
reviewed
Sep 14, 2022
contentcuration/contentcuration/frontend/channelList/views/Channel/ChannelItem.vue
Outdated
Show resolved
Hide resolved
bjester
requested changes
Sep 14, 2022
Member
There was a problem hiding this comment.
The layout changes when you click the link to select channels for download, which adds checkboxes to each channel item row, and that causes them to overflow out of the viewport with the 100% width fix. This is using flexbox so that's an option here. Let me know if you'd like more info on that.
| Before | After |
|---|---|
![]() |
![]() |
…n CatalogList.vue file to correctly update the channel cards width
bjester
approved these changes
Sep 16, 2022
This was referenced Sep 19, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


… fill horizontal space
Summary
Description of the change(s) you made
This PR adds a channel-card class to the list of channels under content-library and sets the
displaytoinline-blockand themin-widthto100%. Previously, channels without descriptions did not completely fill the horizontal space.Manual verification steps performed
Screenshots (if applicable)
Channel card layout without description:

Channel card layout with description:

Channel card layout without description after changes:

On smaller screen:
Reviewer guidance
How can a reviewer test these changes?
References
Fixes issue #3387
Comments
Contributor's Checklist
PR process:
Studio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)