Skip to content

Removes guest string#3609

Merged
bjester merged 1 commit intolearningequality:unstablefrom
akolson:guest-string-removal
Sep 7, 2022
Merged

Removes guest string#3609
bjester merged 1 commit intolearningequality:unstablefrom
akolson:guest-string-removal

Conversation

@akolson
Copy link
Copy Markdown
Member

@akolson akolson commented Sep 7, 2022

Summary

Description of the change(s) you made

This pr removes "first_name: 'Guest'" as there is no implemented use of it within studio. It also reverts the code back to its old state prior to the string translation changes.

Manual verification steps performed

NA

Does this introduce any tech-debt items?

No


References

Closes #2619

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@akolson akolson marked this pull request as ready for review September 7, 2022 18:15
@akolson akolson mentioned this pull request Sep 7, 2022
24 tasks
Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bjester bjester merged commit 35d29b5 into learningequality:unstable Sep 7, 2022
@akolson akolson deleted the guest-string-removal branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Guest" should be translated

2 participants