Sets ‘has captions or subtitles accessibility’ label#3608
Merged
LianaHarris360 merged 4 commits intolearningequality:unstablefrom Sep 8, 2022
Merged
Sets ‘has captions or subtitles accessibility’ label#3608LianaHarris360 merged 4 commits intolearningequality:unstablefrom
LianaHarris360 merged 4 commits intolearningequality:unstablefrom
Conversation
…itle file language is the same as the video file language
rtibbles
requested changes
Sep 8, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Fix works as described, code changes make sense. Just one debugging statement to remove.
| subtitleFileLanguageComparison(file) { | ||
| if (this.oneSelected && this.language === file.language) { | ||
| this.accessibility = [...this.accessibility, AccessibilityCategories.CAPTIONS_SUBTITLES]; | ||
| console.log({ ...this.accessibility }); |
Member
There was a problem hiding this comment.
Should remove this debugging statement.
| // Note: audio is not included, as it is rendered in the UI differently. | ||
| document: ['ALT_TEXT', 'HIGH_CONTRAST', 'TAGGED_PDF'], | ||
| video: ['SIGN_LANGUAGE', 'AUDIO_DESCRIPTION'], | ||
| video: ['SIGN_LANGUAGE', 'AUDIO_DESCRIPTION', 'CAPTIONS_SUBTITLES'], |
Member
There was a problem hiding this comment.
This seems like an important bug fix in its own right!
rtibbles
approved these changes
Sep 8, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This PR checks the ‘has captions or subtitles accessibility’ label automatically if the uploaded subtitle file language is the same as the video file language. The language dropdown placement for the captions and subtitles section was previously shown underneath it but would be cut off. This PR changes the placement of the menu options to show above instead.
Manual verification steps performed
Screenshots (if applicable)
Checked ‘Has captions or subtitles’ checkbox.
Previous placement for language dropdown underneath Captions and subtitles section.
Updated language dropdown placement.
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
References
Fixes #3576
Comments
Note: The ‘Has captions and subtitles’ checkbox label description needs to be updated.
Radina and Jessica agree that the label is descriptive enough and suggest removing the info icon next to the label and reordering this label to be first in the list instead since it’s expected to be the most commonly used option out of those three.
Contributor's Checklist
Studio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)