Skip to content

Data migration updates#3593

Merged
rtibbles merged 3 commits intolearningequality:hotfixesfrom
rtibbles:data_migration_jobs
Sep 6, 2022
Merged

Data migration updates#3593
rtibbles merged 3 commits intolearningequality:hotfixesfrom
rtibbles:data_migration_jobs

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Fixes a remaining bug with the set file duration job whereby even with a fully streamed file, the duration cannot be inferred
  • Adds a management command and make file entry to infer whether video resource nodes should have the has captions metadata applied to them, and applies it

Manual verification steps performed

  1. Ran the new management command, confirmed that it added the label for a node with subtitles that matched the language of the video.
  2. Ran it again and confirmed no additional nodes were updated

Screenshots (if applicable)

First run:

Setting 'has captions' for video kinds
INFO:command:Setting 'has captions' for video kinds
Set has captions metadata for 1 nodes
INFO:command:Set has captions metadata for 1 nodes
Finished setting all has captions metadata for 1 nodes in 0.044237375259399414 seconds
INFO:command:Finished setting all has captions metadata for 1 nodes in 0.044237375259399414 seconds

Second run:

Setting 'has captions' for video kinds
INFO:command:Setting 'has captions' for video kinds
Finished setting all has captions metadata for 0 nodes in 0.02699899673461914 seconds
INFO:command:Finished setting all has captions metadata for 0 nodes in 0.02699899673461914 seconds

References

Fixes #3577

Copy link
Copy Markdown
Member

@vkWeb vkWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! The code works as intended on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants