Remove deprecated Raven pip dependency.#3581
Merged
bjester merged 1 commit intolearningequality:unstablefrom Aug 29, 2022
Merged
Remove deprecated Raven pip dependency.#3581bjester merged 1 commit intolearningequality:unstablefrom
bjester merged 1 commit intolearningequality:unstablefrom
Conversation
bjester
reviewed
Aug 29, 2022
| def handle_server_error(request): | ||
| client.captureException(stack=True, tags={"url": request.path}) | ||
| def handle_server_error(e, request): | ||
| capture_exception(e, tags={"url": request.path}) |
Member
There was a problem hiding this comment.
I'm having trouble identifying whether tags is supported here. The documentation details a different example
Member
Author
There was a problem hiding this comment.
Yeah, I had to go to the source code to verify.
Ultimately it gets set on a transient scope using this function: https://github.com/getsentry/sentry-python/blob/master/sentry_sdk/scope.py#L451
bjester
approved these changes
Aug 29, 2022
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Removes the Python Raven dependency that was still being used, in favour of the sentry_sdk.
Manual verification steps performed
I followed the migration guide here: https://docs.sentry.io/platforms/python/migration/