Skip to content

Ignore any imports of vuetify src style files to defer to our vendored css#3570

Merged
marcellamaki merged 1 commit intolearningequality:unstablefrom
rtibbles:rtl_trever
Aug 26, 2022
Merged

Ignore any imports of vuetify src style files to defer to our vendored css#3570
marcellamaki merged 1 commit intolearningequality:unstablefrom
rtibbles:rtl_trever

Conversation

@rtibbles
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

  • Fixes regression from the removal of vuetify-loader whereby source styles for Vuetify were now being imported, clashing with our vendored and excluded vuetify.css
  • Adds a webpack ignore plugin to ignore these imports
  • Fixes RTL issues

Manual verification steps performed

  1. Switch to Arabic.
  2. Confirm RTL works

Screenshots (if applicable)

Screenshot from 2022-08-22 17-43-34

References

Fixes #3499

@rtibbles rtibbles requested a review from marcellamaki August 23, 2022 00:48
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, manual qa 👍

@marcellamaki marcellamaki merged commit 6c7cb87 into learningequality:unstable Aug 26, 2022
@pcenov
Copy link
Copy Markdown
Member

pcenov commented Sep 27, 2022

I've reported the following as follow-up issues: #3688 and #3689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable - The main navigation remains open after changing the language to Arabic

3 participants