Add 'new' to Intl.ListFormat#3549
Merged
rtibbles merged 1 commit intolearningequality:unstablefrom Aug 17, 2022
Merged
Conversation
rtibbles
approved these changes
Aug 17, 2022
Member
rtibbles
left a comment
There was a problem hiding this comment.
Weird, I guess the error you saw for this previously was due to something else? Maybe the polyfill causing issues? Have confirmed that the constructor does indeed work like this.
This was referenced Sep 15, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
At some point (I think during linting), I dropped the
newfromThis caused an error when rendering any lists (reported in the accessibility criteria, but I suspect it would be anywhere multiple items can be selected).
Manual verification steps performed
View Detail- the content should display and there should be no console errors.Screenshots (if applicable)
Reviewer guidance
How can a reviewer test these changes?
See manual verification steps above
Are there any risky areas that deserve extra testing?
I think that we should wait to consider this "done" until the issue with the chips is resolved. While on the code side, I don't see how there would be any difference, I do think it would be good to double check and make sure there isn't anything I'm not accounting for in the lists.
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)