Skip to content

Upgrade to python 3.9#3522

Merged
bjester merged 2 commits intolearningequality:unstablefrom
bjester:upgrade-python-3.9
Aug 11, 2022
Merged

Upgrade to python 3.9#3522
bjester merged 2 commits intolearningequality:unstablefrom
bjester:upgrade-python-3.9

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Aug 11, 2022

Summary

Description of the change(s) you made

  • Updates docker images, including production's, to use python:3.9-slim-buster base, thereby upgrading python to 3.9
  • Other relevant changes making the new minimum supported version of studio to be 3.9
  • Upgrades celery to 5.2.7

Manual verification steps performed

  1. Ran make dcbuild then make dcup and everything ran fine through docker
  2. Ran docker build -f k8s/images/app/Dockerfile . and built the production image successfully

Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

  • I suspect that once we merge this, dependabot will help upgrade all the packages for us?

References

Resolves #3474

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from rtibbles August 11, 2022 20:31
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's something wrong in here, I've not spotted it!

@bjester bjester merged commit d5e5fff into learningequality:unstable Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade the minimum version of python for Studio

2 participants