Skip to content

Adjust the reset interval, and logic to prevent excess resets#3482

Merged
bjester merged 1 commit intolearningequality:unstablefrom
bjester:analytics-reset
Aug 5, 2022
Merged

Adjust the reset interval, and logic to prevent excess resets#3482
bjester merged 1 commit intolearningequality:unstablefrom
bjester:analytics-reset

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Aug 4, 2022

Summary

Description of the change(s) you made

From feedback given by @MisRob:

  • I increased the reset interval to 5 minutes
  • Prevented requeuing of the reset function if the dataLayer hasn't changed
  • Added logic to stop processing of dataLayer items once it reaches the queued reset function

Manual verification steps performed

  1. Opened the channel edit page
  2. Clicked around, generating events
  3. Left the tab idle for a while
  4. Verified that reset was triggered
  5. Continued to leave the tab idle
  6. Verified that additional resets were skipped until new events occur

References

#3475 (comment)

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Copy Markdown
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bjester, everything's looking good to me

@bjester bjester merged commit fc7e057 into learningequality:unstable Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants