Skip to content

Add missing coach icon to resource item, consolidate color of coach icon#3476

Merged
rtibbles merged 3 commits intolearningequality:unstablefrom
bjester:role-visibility
Aug 3, 2022
Merged

Add missing coach icon to resource item, consolidate color of coach icon#3476
rtibbles merged 3 commits intolearningequality:unstablefrom
bjester:role-visibility

Conversation

@bjester
Copy link
Copy Markdown
Member

@bjester bjester commented Aug 2, 2022

Summary

Description of the change(s) you made

  • Adds missing coach content icon to an individual resource
  • Updates uses of the icon to use the standard color in the designs

Manual verification steps performed

  1. Added coach content
  2. Verified the icon showed appropriately

Screenshots (if applicable)

Screenshot from 2022-08-02 13-36-43
Screenshot from 2022-08-02 13-37-02
Screenshot from 2022-08-02 13-37-22
Screenshot from 2022-08-02 13-43-04

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Does the icon show when it should?
Does it cause visual issues?

References

Fixes #3338

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested a review from marcellamaki August 2, 2022 20:47
@bjester bjester requested a review from jtamiace August 2, 2022 20:48
Copy link
Copy Markdown
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - manual testing checks out!

@rtibbles rtibbles merged commit 395aeb9 into learningequality:unstable Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Coach content icons missing from resources

2 participants